Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests]: Mark test_statistics.test_kde_random with a requires_resource('cpu') decorator #118801

Merged
merged 1 commit into from
May 9, 2024
Merged

[tests]: Mark test_statistics.test_kde_random with a requires_resource('cpu') decorator #118801

merged 1 commit into from
May 9, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented May 8, 2024

This is a CPU-intensive test. On my machine (Ryzen 7 4800H, 8/16), it takes about 80 seconds.

./python -m test -v test_statistics -m test_kde_random
== CPython 3.14.0a0 (heads/main:cb6f75a32c, May 8 2024, 23:39:14) [GCC 9.4.0]
== Linux-5.10.16.3-microsoft-standard-WSL2-x86_64-with-glibc2.31 little-endian
== Python build: free_threading debug
== cwd: /home/eclips4/CLionProjects/cpython/build/test_python_worker_26032æ
== CPU count: 16
== encodings: locale=UTF-8 FS=utf-8
== resources: all test resources are disabled, use -u option to unskip tests

Using random seed: 1617172693
0:00:00 load avg: 0.15 Run 1 test sequentially
0:00:00 load avg: 0.15 [1/1] test_statistics
test_kde_random (test.test_statistics.TestKDE.test_kde_random) ... ok

----------------------------------------------------------------------
Ran 1 test in 80.244s

OK
test_statistics passed in 1 min 20 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1 min 20 sec
Total tests: run=1 (filtered)
Total test files: run=1/1 (filtered)
Result: SUCCESS

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels May 8, 2024
@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label May 8, 2024
@Eclips4 Eclips4 changed the title [tests]: Mark `test_statistics.test_kde_random with a requires_resource('cpu') decorator [tests]: Mark test_statistics.test_kde_random with a requires_resource('cpu') decorator May 8, 2024
@sobolevn sobolevn merged commit 027e6d8 into python:main May 9, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@Eclips4 @miss-islington
[tests]: Mark test_statistics.test_kde_random with a ``requires_r…
97f8089 
…esource('cpu')`` decorator (pythonGH-118801)

Mark test_kde_random with a requires_resource('cpu') decorator
(cherry picked from commit 027e6d8)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

GH-118818 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
@sobolevn
Copy link
Member

sobolevn commented May 9, 2024

What about 3.12 backport?

@Eclips4
Copy link
Member Author

Eclips4 commented May 9, 2024

What about 3.12 backport?

This test was not backported to the 3.12 branch, so there is no need to backport it there.

@Eclips4 Eclips4 deleted the decorator_for_kde_random branch May 9, 2024 08:24
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.x has failed when building commit 027e6d8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1232/builds/2294) and take a look at the build logs.
  4. Check if the failure is related to this commit (027e6d8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1232/builds/2294

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 1039, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 990, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_interpreters/test_stress.py", line 29, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "<frozen getpath>", line 355, in <module>
ValueError: embedded null byte
Warning -- Uncaught thread exception: InterpreterError
Exception in thread Thread-124 (task):
RuntimeError: error evaluating path

@Eclips4 Eclips4 mentioned this pull request May 9, 2024
Closed
@Eclips4
Copy link
Member Author

Eclips4 commented May 9, 2024

Buildbot failure is unrelated; I've created #118823 to track this.

sobolevn pushed a commit that referenced this pull request May 9, 2024
@miss-islington @Eclips4
[3.13] [tests]: Mark test_statistics.test_kde_random with a ``req…
09896fc 
…uires_resource('cpu')`` decorator (GH-118801) (#118818)

[tests]: Mark ``test_statistics.test_kde_random`` with a ``requires_resource('cpu')`` decorator (GH-118801)

Mark test_kde_random with a requires_resource('cpu') decorator
(cherry picked from commit 027e6d8)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
@Eclips4 Eclips4 mentioned this pull request Jun 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Eclips4 @sobolevn @bedevere-bot @JelleZijlstra